Feature branches/localsceneview compose #1035
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Basic LocalSceneView and app * Add content and event handler * Viewpoint events * Add doc * Add interaction options * Start on proxy * Add screen to location to proxy * More params * Update for API change * Remove things from geoview that are not really supported * Fix some names * Fix end of file * Update API * Readme and screenshot for LSV app * Fix file name * Add more to readme * Add a viewpoint method * Add viewpoint methods * Add viewpoint method * Preserve viewpoitn instead of camera * Update API * Time extent is not currently supported * Reorder parameters * Start adding params * Update .api * Add params doc * Add default duration of 3 seconds * Update .api * Reorder params so defaulted value comes last
* Copy API doc * Code review updates
gunt0001
reviewed
Nov 19, 2025
Collaborator
gunt0001
left a comment
gunt0001
left a comment
There was a problem hiding this comment.
@colinanderson - looks good. A few things worth adding to this PR:
- In the main readme, where it says "GeoView-Compose - Compose wrappers for the MapView and SceneView." -> could you enhance this to:
"GeoView-Compose - Compose wrappers for the MapView, SceneView and LocalSceneView." - In the geoview-compose readme:
- where it says "The GeoView-Compose module provides @composable implementations of the MapView and SceneView with a Compose-idiomatic API." -> Could you enhance this to:
"The GeoView-Compose module provides @composable implementations of the MapView, SceneView and LocalSceneView with a Compose-idiomatic API." - under "Other Examples", could you add a link to the LSV micro app
- where it says "The GeoView-Compose module provides @composable implementations of the MapView and SceneView with a Compose-idiomatic API." -> Could you enhance this to:
Collaborator
Author
|
@gunt0001 doc links etc added. Please have another look. |
gunt0001
approved these changes
Nov 20, 2025
Collaborator
gunt0001
left a comment
gunt0001
left a comment
There was a problem hiding this comment.
@colinanderson - looks good 👍
sorenoid
approved these changes
Nov 20, 2025
Collaborator
sorenoid
left a comment
sorenoid
left a comment
There was a problem hiding this comment.
One issue created to cover some possible shortcomings in doc in the next release.
Collaborator
There was a problem hiding this comment.
this file doesn't seem to completely cover LocalSceneView, but I am not sure of the limitations of it at this time. I created an issue to review this for 300 https://devtopia.esri.com/runtime/kotlin/issues/6944
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to issue: https://devtopia.esri.com/runtime/red-october/issues/2852 https://devtopia.esri.com/runtime/kotlin/issues/6704
Description:
Merge feature branch of LSV in to v.next
Summary of changes:
Pre-merge Checklist