[New] (300.0) Filter building scene layer #731
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zkline101
requested review from
a team and
philium
and removed request for
a team
yo1995
reviewed
Nov 27, 2025
| import SwiftUI | ||
|
|
||
| extension FilterBuildingSceneLayerView { | ||
| /// The building group sublayer toggle which has a toggle for the visbility of the group |
Collaborator
There was a problem hiding this comment.
Suggested change
| /// The building group sublayer toggle which has a toggle for the visbility of the group | |
| /// The building group sublayer toggle which has a toggle for the visibility of the group |
| /// - Parameter groupSublayer: The group sublayer which is used to build this view. | ||
| init(groupSublayer: BuildingGroupSublayer) { | ||
| // Sets the initial value of the toggle to the | ||
| // current visbility of the group sublayer. |
Collaborator
There was a problem hiding this comment.
Suggested change
| // current visbility of the group sublayer. | |
| // current visibility of the group sublayer. |
| /// - Parameter sublayer: The sublayer to help build this view. | ||
| init(sublayer: BuildingSublayer) { | ||
| // Sets the initial value of the toggle to the | ||
| // current visbility of the sublayer. |
Collaborator
There was a problem hiding this comment.
Suggested change
| // current visbility of the sublayer. | |
| // current visibility of the sublayer. |
| Button("Settings", systemImage: "gear") { | ||
| settingsAreVisible = true | ||
| } | ||
| .popover(isPresented: $settingsAreVisible) { [settings] in |
Collaborator
There was a problem hiding this comment.
Does the settings need to be captured?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements
Filter building scene layerinLayerscategory.URL to README:
(There is a known issue where the basemap doesn't render sometimes)
How To Test
Screenshots