fix: add defaultSort parameter to fetchAllWithPagination #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes issue where 'all' items preview fails to load without the sort parameter. Pass defaultSort['all'] to ensure proper database query execution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Add defaultSort parameter to fetchAllWithPagination
Problem
When running locally, the "all" items preview fails to load without explicitly passing the sort parameter. This causes the market view to appear empty.
Solution
Pass
defaultSort['all']tofetchAllWithPaginationin thefetchAll$effect.Testing
Notes
I noticed production works fine at sepolia.etherphunks.eth.limo - this may be an environment-specific issue or already fixed in unreleased code, but this ensures the public codebase works for local development.