build(deps): lock ilt-panphon and bump g2p#770
Merged
Conversation
I manually reviewed the license and it is OK, so we can skip auto analysis.
With g2p <2.3, we had locked panphon==0.20.0, which was fine, locking the PFS input feature vectors coded in panphon. With g2p 2.3.0, we have a problem, because g2p no longer uses panphon, instead, it uses ilt-panphon, which installs in the same namespace. So now, we're getting the latest ilt-panphon with different PFS input vectors, by accident. The complex requirements we need to specify is: g2p>=2.0,<2.3 with panphon==0.20.0 or g2p>=2.3.1 with ilt-panphon==0.20.1 but such logic cannot be expressed in a pyproject.toml file, so isntead we just require the latest g2p with the corresponding version of ilt-panphon.
|
Review changes with Changed Files
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #770 +/- ##
=======================================
Coverage 82.76% 82.76%
=======================================
Files 47 47
Lines 4119 4119
Branches 607 607
=======================================
Hits 3409 3409
Misses 579 579
Partials 131 131 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Goal?
With g2p <2.3, we had locked panphon==0.20.0, which was fine, locking
the PFS input feature vectors coded in panphon.
With g2p 2.3.0, we have a problem, because g2p no longer uses panphon,
instead, it uses ilt-panphon, which installs in the same namespace. So
now, we're getting the latest ilt-panphon with different PFS input
vectors, by accident.
The complex requirements we need to specify is:
but such logic cannot be expressed in a pyproject.toml file, so isntead
we just require the latest g2p with the corresponding version of
ilt-panphon.
Fixes?
Broken CI, visible on #769 workflows, or if we run tests on main right now.
Feedback sought?
Priority?
high
Tests added?
How to test?
Confidence?
high
Version change?
no
Related PRs?
Depends on publishing g2p 2.3.1, forthcoming.