Skip to content

fix packages#285

Open
ciglenecki wants to merge 1 commit intoEvolution0:masterfrom
ciglenecki:master
Open

fix packages#285
ciglenecki wants to merge 1 commit intoEvolution0:masterfrom
ciglenecki:master

Conversation

@ciglenecki
Copy link
Copy Markdown

@ciglenecki ciglenecki commented Mar 14, 2026

packages were not hard locked and installing via pip/uv produced an error

these changes allow out of the box installation with both pip and uv, and support python3.13+ versions as well

error before

Traceback (most recent call last):
  File "$HOME/venv/bin/bandcamp-dl", line 6, in <module>
    sys.exit(main())
             ~~~~^^
  File "$HOME/venv/lib/python3.13/site-packages/bandcamp_dl/__main__.py", line 132, in main
    bandcamp_downloader.start(album)
    ~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^
  File "$HOME/venv/lib/python3.13/site-packages/bandcamp_dl/bandcampdownloader.py", line 52, in start
    self.download_album(album)
    ~~~~~~~~~~~~~~~~~~~^^^^^^^
  File "$HOME/venv/lib/python3.13/site-packages/bandcamp_dl/bandcampdownloader.py", line 151, in download_album
    filepath = self.template_to_path(track_meta, self.config.ascii_only,
                                     self.config.ok_chars, self.config.space_char,
                                     self.config.keep_spaces, self.config.keep_upper)
  File "$HOME/venv/lib/python3.13/site-packages/bandcamp_dl/bandcampdownloader.py", line 91, in template_to_path
    self.logger.debug(f'Track artist is None, replacing with {slugify_preset(track["albumartist"])}')
                                                              ~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^
  File "$HOME/venv/lib/python3.13/site-packages/bandcamp_dl/bandcampdownloader.py", line 71, in slugify_preset
    slugged = slugify.slugify(content, ok=ok_chars, only_ascii=ascii_only,
                              spaces=keep_space, lower=not keep_upper,
                              space_replacement=space_char)
TypeError: slugify() got an unexpected keyword argument 'ok'

@Evolution0
Copy link
Copy Markdown
Owner

This will cause a regressing reintroducing the syntax warning since 3.12 caused by unicode-slugify, the official release build which you now hard locked is from 2021, a PR was made some time back that fixed the issue but mozilla doesn't seem interested in merging it which is why its set to that PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants