fix: remove redundant base64 handler

[Cranbaerry]

📋 Description

This part of the code returns
{
"status": 500,
"error": "Internal Server Error",
"response": {
"message": "Cannot read properties of null (reading 'mediaUrl')"
}
}

in /findChats/ API endpoint, e.g:

http://localhost:8080/chat/findChats/EVO-EED-4754-J

🔗 Related Issue

None created yet

🧪 Type of Change

• [X ] 🐛 Bug fix (non-breaking change which fixes an issue)
• ✨ New feature (non-breaking change which adds functionality)
• 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
• 📚 Documentation update
• 🔧 Refactoring (no functional changes)
• ⚡ Performance improvement
• 🧹 Code cleanup
• 🔒 Security fix

🧪 Testing

• [X ] Manual testing completed
• [X ] Functionality verified in development environment
• [ X] No breaking changes introduced
• [ ]X Tested with different connection types (if applicable)

📸 Screenshots (if applicable)

✅ Checklist

• My code follows the project's style guidelines
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have manually tested my changes thoroughly
• I have verified the changes work with different scenarios
• Any dependent changes have been merged and published

📝 Additional Notes

Summary by Sourcery

Streamline ChannelStartupService’s message cleaning by removing unnecessary base64 and mediaUrl handling to prevent runtime errors

Bug Fixes:

• Fix Internal Server Error in /findChats by removing redundant mediaUrl extraction and assignment that caused null dereference

Enhancements:

• Simplify deletion of base64 property to only remove it when present and eliminate duplicate deletes

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Refactors base64 handling in ChannelStartupService by dropping redundant mediaUrl backup/restore and simplifying the deletion of the base64 field within the message existence check.

Class diagram for updated ChannelStartupService message cleaning

classDiagram
class ChannelStartupService {
  +cleanedMessage: object
  +cleanMessage(message: object): object
}
class Message {
  base64: string
  mediaUrl: string
  imageMessage: object
}
ChannelStartupService --|> Message

%% Changes:
%% - Removed redundant mediaUrl backup/restore logic
%% - Simplified base64 field deletion within message existence check
%% - No longer restores mediaUrl after cleaning

Loading

File-Level Changes

Change	Details	Files
Removed redundant mediaUrl extraction and restore	Deleted the assignment of mediaUrl from cleanedMessage.message Removed reinsertion of mediaUrl at the end of the handler	src/api/services/channel.service.ts
Simplified base64 field deletion logic	Relocated delete cleanedMessage.message.base64 inside the message existence block Added a conditional check before deleting base64	src/api/services/channel.service.ts

Possibly linked issues

• #Erro 500 na listagem de Chats: PR removes redundant base64 handler, fixing the 'Cannot read properties of null (reading 'mediaUrl')' error in /chat/findChats/.

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey there - I've reviewed your changes - here's some feedback:

• There’s a duplicate delete of cleanedMessage.message.base64; remove the redundant invocation to avoid confusion.
• You’ve removed the mediaUrl preservation logic—double-check that this won’t inadvertently strip mediaUrl from your API response.
• Consider flattening the base64 cleanup block instead of nested ifs to improve readability.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- There’s a duplicate delete of cleanedMessage.message.base64; remove the redundant invocation to avoid confusion.
- You’ve removed the mediaUrl preservation logic—double-check that this won’t inadvertently strip mediaUrl from your API response.
- Consider flattening the base64 cleanup block instead of nested ifs to improve readability.

## Individual Comments

### Comment 1
<location> `src/api/services/channel.service.ts:539-540` </location>
<code_context>
-    delete cleanedMessage.message.base64;
-
     if (cleanedMessage.message) {
+      if (cleanedMessage.message.base64) {
+        delete cleanedMessage.message.base64;
+      }
+
</code_context>

<issue_to_address>
**suggestion:** Redundant deletion of 'base64' property from cleanedMessage.message.

Only one deletion is needed; please remove the redundant statement.
</issue_to_address>

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[sourcery-ai]

suggestion: Redundant deletion of 'base64' property from cleanedMessage.message.

Only one deletion is needed; please remove the redundant statement.