-
Notifications
You must be signed in to change notification settings - Fork 101
Speedup ABLStats #1726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Speedup ABLStats #1726
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Before change in compute_zi: After: 1.5X speedup for total simulation. |
817972c to
3fd53b0
Compare
|
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
4fb9011 to
16aac77
Compare
1cfc080 to
ef1a6a1
Compare
dd331e1 to
83432e7
Compare
Contributor
Author
jrood-nrel
approved these changes
Nov 4, 2025
Contributor
Author
|
This was kind of a big deal actually. It improves the scaling quite a bit. Thanks @jrood-nrel for running this out.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.


Summary
This speeds up the ABL stats considerably. For the precursor I was profiling,
compute_zitook 27% of the total runtime (!). This takes it down to just 1%. Currently just for nvidia GPU. Need to generalize.More granular profiling of the ABLStats.
Pull request type
Please check the type of change introduced:
Checklist
The following is included:
This PR was tested by running:
Additional background
Issue Number: