Skip to content

Conversation

@mchurchf
Copy link
Contributor

Summary

Added functionality to ABLForcing to damp the free atmosphere wind back toward the geostrophic wind that the ABLForcing converges upon.

Pull request type

Draft

Please check the type of change introduced:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Checklist

The following is included:

  • new unit-test(s)
  • new regression test(s)
  • documentation for new capability

This PR was tested by running:

  • the unit tests
    • on GPU
    • on CPU
  • the regression tests
    • on GPU
    • on CPU

Additional background

Issue Number:

Comment on lines +105 to +106
ifh.ignore(
std::numeric_limits<std::streamsize>::max(), '\n');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These code lines are here to skip the header line in the data file. This ignore statement needs to be first, prior to the loop.

Comment on lines +176 to +177
ifh.ignore(
std::numeric_limits<std::streamsize>::max(), '\n');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These code lines are here to skip the header line in the data file. This ignore statement needs to be first, prior to the loop.

while (ifh >> data_time >> data_value) {
m_nearsurf_temp_time.push_back(data_time);
m_nearsurf_temp_value.push_back(data_value);
ifh.ignore(std::numeric_limits<std::streamsize>::max(), '\n');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code line is here to skip the header line in the data file. This ignore statement needs to be first, prior to the loop.

flux = 0.0012 * wspd_mean * (theta_surface - theta_mean);
break;
case amr_wind::MOData::ThetaCalcType::NEAR_SURFACE_TEMPERATURE:
amrex::Print() << "To be implemented..." << std::endl;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this print statement is causing the GPU-related checks to fail. No worries for now!

@mbkuhn
Copy link
Contributor

mbkuhn commented Oct 6, 2025

Hey Matt! Any updates on this capability? Is it still a work in progress, and would you like me to pitch in any way? If this will be picked up later down the road, we could convert the PR to draft.

@github-actions
Copy link

github-actions bot commented Nov 6, 2025

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions
Copy link

This PR was closed because it has been stalled for 7 days with no activity.

@github-actions github-actions bot closed this Nov 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants