refactor: cleaner bounds check in utf8.js deLoose#54
Merged
Conversation
Co-authored-by: ChALkeR <291301+ChALkeR@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Review codebase and identify mistakes
Fix off-by-one bounds check in utf8.js deLoose function
Jan 28, 2026
Collaborator
|
This has no real effect but makes sense for code clarity |
ChALkeR
approved these changes
Feb 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
deLoosefunction searches for UTF-8 replacement character sequences (0xEF 0xBF 0xBD) but had an off-by-one error allowing out-of-bounds reads.Changes
utf8.js: Fixed bounds check when searching for 3-byte replacement sequencelast = res.length - 2→last = res.length - 3(last valid position to read 3 consecutive bytes)start < last→start <= lastpos > lastguard afterindexOfto prevent OOB access when 0xEF found near array endOriginal prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.