Conversation
f9588bd to
2abbcca
Compare
3e18570 to
b7bb8a0
Compare
b7bb8a0 to
5d30e2c
Compare
There was a problem hiding this comment.
Pull request overview
Adds first-class 'arraybuffer' output support across the bytes encoding/decoding APIs, aligning runtime behavior, TypeScript declarations, and test coverage to resolve #65.
Changes:
- Extend output format handling to support returning
ArrayBuffer(runtime + typings). - Update TypeScript overloads across utf8/hex/base32/base64/base58/base58check/bigint modules to include
'arraybuffer'. - Expand test suites to validate
'arraybuffer'output across affected modules.
Reviewed changes
Copilot reviewed 9 out of 17 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
fallback/_utils.js |
Adds 'arraybuffer' handling to fromUint8 / fromBuffer conversion helpers. |
array.d.ts |
Expands OutputFormat to include 'arraybuffer'; adjusts typed array helper signatures accordingly. |
utf8.d.ts |
Adds 'arraybuffer' overloads/return unions for UTF-8 encoding functions. |
hex.d.ts |
Adds 'arraybuffer' overload/union return type for fromHex. |
bigint.d.ts |
Adds 'arraybuffer' overload/union return type for fromBigInt. |
base64.d.ts |
Adds 'arraybuffer' overloads/union return types for base64 decoders. |
base32.d.ts |
Adds 'arraybuffer' overloads/union return types for base32 decoders. |
base58.d.ts |
Adds 'arraybuffer' overloads/union return types for base58 decoders. |
base58check.d.ts |
Adds 'arraybuffer' overloads/union return types for base58check decoders (async + sync). |
tests/utf8.test.js |
Adds 'arraybuffer' to invalid-format coverage and validates 'arraybuffer' output roundtrips. |
tests/utf8.lib.test.js |
Mirrors UTF-8 'arraybuffer' coverage for library import path. |
tests/hex.test.js |
Adds 'arraybuffer' decoding assertions and fixtures pool tracking. |
tests/bigint.test.js |
Adds 'arraybuffer' format assertions for fromBigInt. |
tests/base64.test.js |
Adds 'arraybuffer' format assertions for base64/base64url decoders. |
tests/base32.test.js |
Adds 'arraybuffer' format assertions for base32/base32hex decoders. |
tests/base58.test.js |
Adds 'arraybuffer' format assertions and adjusts non-pooled tracking exclusions. |
tests/base58check.test.js |
Adds 'arraybuffer' format assertions and adjusts non-pooled tracking exclusions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #65