feature(proxy): support brotli compression#852
Draft
sullis wants to merge 2 commits intoExpediaGroup:masterfrom
Draft
feature(proxy): support brotli compression#852sullis wants to merge 2 commits intoExpediaGroup:masterfrom
sullis wants to merge 2 commits intoExpediaGroup:masterfrom
Conversation
Author
|
cc: @hyperxpro |
sullis
force-pushed
the
sean/support-brotli-compression
branch
from
818c325 to
0cede14
Compare
sullis
changed the title
sullis
force-pushed
the
sean/support-brotli-compression
branch
from
0cede14 to
a265ce5
Compare
sullis
force-pushed
the
sean/support-brotli-compression
branch
from
a265ce5 to
bf7d7a3
Compare
hyperxpro
suggested changes
Mar 14, 2024
| @Test | ||
| @EnabledOnOs(value = { OS.LINUX, OS.MAC }) | ||
| public void brotliCompressionIsAvailable() throws Throwable { | ||
| Brotli.ensureAvailability(); |
There was a problem hiding this comment.
You can remove this because the below assert will fail if the native library is not available.
Author
There was a problem hiding this comment.
👍 I just pushed an update. I removed BrotliTest.java and moved 1 assertion into HttpCompressorTest
Author
|
@kenluluuuluuuuu this PR is a proof of concept. Please let me know what you think. |
Author
|
@kenluluuuluuuuu is this an active project? |
Contributor
|
Hi @sullis, Appreciate for the effort and your understanding. Thanks, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Context
This PR adds the brotli4j library.
Netty 4.x will automatically detect the presence of brotli4j.
When brotli4j is on the runtime classpath, Netty enables brotli compression.
If brotli4j is missing from the runtime classpath, Netty does not provide brotli compression.