Upgrade react native to 0.72.4 #27320

fabOnReact · 2023-09-13T09:56:40Z

Details

Update react-native to 0.72.4 as suggested by the upgrade-helper and the slack instructions.

Patches not yet merged in upstream that have been re-applied on 0.72.4 with a new patch.

NumberOfLines (patch, github discussion)
VerticalScrollBarPosition (patch, pr)

Patches that had no issues with 0.72.4:

Image manipulator (upstream)
react-native-sdk (patch, upstream).
react-navigation-native (patch, upstream)
react-navigation+stack+6.3.16+001+initial
react-navigation+stack+6.3.16+002+dontDetachScreen
react-native+0.72.4+001+initial
react-native+0.72.3+004+ModalKeyboardFlashing (patch)
react-native-fast-image (patch)
react-native-modal (patch)
Vision-camera (patch)
React-native-web-lottie (patch)
react-navigation/material-top-tabs (patch), available with version 7.0.0-alpha.3, react-navigation should be updated with a separate PR (more info)

Fixed Issues

$ #21411
PROPOSAL: #21411 (comment)

Tests

Verify that no errors appear in the JS console

Linkified email from external app is pasted as linkified email in email field:

Copy text that contains a link using the android mobile browser (for example chrome)
Open an Expensify Chat on an Android Device
Paste the previously copied link in the chat Expensify Composer (TextInput).

Expected Result: The link is pasted as plain text and not rich text.

Offline tests

Same as above.

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Screen.Recording.2023-09-13.at.5.29.10.PM.mov

Mobile Web - Chrome

mobile-chrome-web-copy-paste-test.webm

Mobile Web - Safari

Simulator.Screen.Recording.-.iPhone.14.Pro.-.2023-09-13.at.17.31.59.mp4

Desktop

Screen.Recording.2023-09-13.at.5.24.11.PM.mov

iOS

Simulator.Screen.Recording.-.iPhone.14.Pro.-.2023-09-13.at.17.12.52.mp4

Android

copy-paste-test-android.webm

ds300/patch-package#455

github-actions · 2023-09-13T09:56:58Z

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

fabOnReact · 2023-09-13T10:00:52Z

I have read the CLA Document and I hereby sign the CLA

fabOnReact · 2023-09-14T05:38:06Z

Patch NumberOfLines

Test cases 0.72.3 #18507 (comment)
PR Android facebook/react-native#35703
PR iOS facebook/react-native#38021

Test Cases 0.72.4 - iOS
https://github.com/Expensify/App/assets/24992535/8fc53f54-8389-4010-aedd-b7fbffe6186d

Test Cases 0.72.4 - Android

Screen.Recording.2023-09-13.at.3.35.41.PM.mov

melvin-bot · 2023-09-16T07:13:49Z

@s77rt Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

s77rt · 2023-09-17T13:19:23Z

@fabriziobertoglio1987

Patches not yet merged in upstream that have been re-applied on 0.72.4 with a new patch.

Image manipulator and react-native-sdk does not seem to require a new patch. We are using the same patch, right? If so please move those to the "Patches that had no issues with 0.72.4" section.

s77rt · 2023-09-17T16:02:09Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

mweb-chrome.mov

Mobile Web - Safari

mweb-safari.mov

Desktop

iOS

ios.mov

Android

android.mov

fabOnReact · 2023-09-18T05:10:59Z

Image manipulator and react-native-sdk does not seem to require a new patch. We are using the same patch, right? If so please move those to the "Patches that had no issues with 0.72.4" section.

Thanks @s77rt. Yes. We are using the same patch for Image manipulator and react-native-sdk. I moved them to the section "Patches that had no issues with 0.72.4".

Gonals · 2023-09-19T04:44:14Z

We have some conflicts

fabOnReact · 2023-09-19T22:46:22Z

@Gonals Thanks. I rebased and re-tested the functionalities.

OSBotify · 2023-09-20T03:32:57Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-09-20T08:43:45Z

🚀 Deployed to staging by https://github.com/Gonals in version: 1.3.72-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-09-22T13:25:40Z

🚀 Deployed to production by https://github.com/thienlnam in version: 1.3.72-11 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fabOnReact added 10 commits September 10, 2023 18:05

upgrade to rn 0.72.4 + fix patches

657e78a

this patches were not upstreamed, and need to be re-applied to 0.72.4

3219b0e

commit package-lock.json

7db3aa0

update material-top-tabs to 7.0.0-alpha.3

3547e15

re-apply patches react-native-sdk and image-manipulator

d0bb756

all patches work except NumberOfLines and VerticalScrollBar

96252f8

patch NumberOfLines

d90102d

reapply VerticalScrollBarPosition

6a514cd

reapply all patches

239ed53

add back package.json over-rides

2b27c5b

ds300/patch-package#455

fabOnReact mentioned this pull request Sep 13, 2023

[HOLD for payment 2023-09-29] [$1000] Android - Login - Linkified email from external app is pasted as linkified email in email field #21411

Closed

6 tasks

fabOnReact added 3 commits September 14, 2023 12:53

commit Podfile.lock and package-lock.json

ffa0155

Merge branch 'main' into upgrade-react-native-0.72.4

b2935c2

add back material-top-tabs patch

7d5417d

fabOnReact added 2 commits September 14, 2023 16:46

fixing error in patch NumberOfLines

74f733a

rename NumberOfLines patch

c6b245e

fabOnReact marked this pull request as ready for review September 16, 2023 07:13

fabOnReact requested a review from a team as a code owner September 16, 2023 07:13

melvin-bot bot requested review from s77rt and removed request for a team September 16, 2023 07:13

s77rt approved these changes Sep 17, 2023

View reviewed changes

melvin-bot bot requested a review from Gonals September 17, 2023 16:19

Gonals previously approved these changes Sep 19, 2023

View reviewed changes

Merge branch 'main' into upgrade-react-native-0.72.4

acde44c

fabOnReact dismissed Gonals’s stale review via acde44c September 19, 2023 22:30

Gonals approved these changes Sep 20, 2023

View reviewed changes

Gonals merged commit d0b4912 into Expensify:main Sep 20, 2023

OSBotify mentioned this pull request Sep 20, 2023

Deploy Checklist: New Expensify 2023-09-20 #27837

Closed

bernhardoj mentioned this pull request Sep 22, 2023

[HOLD for payment 2023-10-23] [$500] Android native - Default Scrollbar is visible when scrolling in a chat #27931

Closed

6 tasks

Upgrade react native to 0.72.4 #27320

Upgrade react native to 0.72.4 #27320

Uh oh!

Conversation

fabOnReact commented Sep 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Linkified email from external app is pasted as linkified email in email field:

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

github-actions bot commented Sep 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fabOnReact commented Sep 13, 2023

Uh oh!

fabOnReact commented Sep 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Patch NumberOfLines

Uh oh!

melvin-bot bot commented Sep 16, 2023

Uh oh!

s77rt commented Sep 17, 2023

Uh oh!

s77rt commented Sep 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

fabOnReact commented Sep 18, 2023

Uh oh!

Gonals commented Sep 19, 2023

Uh oh!

fabOnReact commented Sep 19, 2023

Uh oh!

OSBotify commented Sep 20, 2023

Uh oh!

OSBotify commented Sep 20, 2023

Uh oh!

OSBotify commented Sep 22, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

fabOnReact commented Sep 13, 2023 •

edited

Loading

github-actions bot commented Sep 13, 2023 •

edited

Loading

fabOnReact commented Sep 14, 2023 •

edited

Loading

s77rt commented Sep 17, 2023 •

edited

Loading