-
Notifications
You must be signed in to change notification settings - Fork 3.5k
chore: upgrade @react-native-clipboard/clipboard to 1.16.3 #78461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade @react-native-clipboard/clipboard to 1.16.3 #78461
Conversation
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR upgrades the @react-native-clipboard/clipboard dependency from version 1.15.0 to 1.16.3 as required by align-deps for the React Native upgrade.
- Updated the clipboard package version in package.json
- Updated corresponding lockfile entries in package-lock.json and iOS Podfile.lock
- No code changes required as the upgrade is backward compatible
Reviewed changes
Copilot reviewed 1 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package.json | Updated @react-native-clipboard/clipboard dependency from ^1.15.0 to ^1.16.3 |
| package-lock.json | Updated lockfile with new version (1.16.3), resolved URL, and integrity hash for the clipboard package |
| ios/Podfile.lock | Updated iOS native dependency RNCClipboard from 1.15.0 to 1.16.3 with corresponding checksum |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Please link this PR below |
Codecov Report✅ All modified and coverable lines are covered by tests. |
|
Why is this [No QA]? There should be at least 1 test case to verify that copy/paste works. Test both plain text and html. |
|
@samranahm Could you address the above comment? Thanks! |
|
@situchan Yes this totally make sense, Let me update the test section to add both test. |
|
@situchan Please take a look. |
situchan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc: @brunovjk for checklist
Reviewer Checklist
Screenshots/VideosAndroid: HybridApp78461_android_native.movAndroid: mWeb Chrome78461_android_web.moviOS: HybridApp78461_ios_native.moviOS: mWeb Safari78461_ios_web.movMacOS: Chrome / Safari78461_web_chrome.mov |
|
I believe it's all yours now @mollfpr. Thank you. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Explanation of Change
bumps
@react-native-clipboard/clipboardas required by align-deps for the React Native upgrade.Fixed Issues
$ #75698
MOBILE-EXPENSIFY: https://github.com/Expensify/Mobile-Expensify/pull/13813
PROPOSAL: #75698 (comment)
Tests
Test 01 - Copy plain text message
Test 02 - Copy HTML message
Offline tests
Same as test
QA Steps
Same as test
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS.Chrome.mp4