-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[Hold Web-E#49954] Remove distance rate index translations and fix enabled message copy #78467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[Hold Web-E#49954] Remove distance rate index translations and fix enabled message copy #78467
Conversation
…pdated field is the 'index' field and delete the updatedCustomUnitRateIndex from the copy and translations
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx ts-node ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@rayane-d can you update the checklist and take it off draft if this is ready for review? |
Explanation of Change
Removes the
updatedCustomUnitRateIndextranslation (since index changes should never be shown to customers) and adds "the" to the enabled/disabled distance rate message for grammatical correctnessMessage format: #75997 (comment)
Web-E PR: https://github.com/Expensify/Web-Expensify/pull/49954
Fixed Issues
Part of #75997
PROPOSAL:
Tests
Prerequisites
Test Steps
Navigate to Settings > Workspaces > [Your Workspace] > More features
Enable Taxes
Navigate to Settings > Workspaces > [Your Workspace] > Taxes
Add some taxes
Click on the Settings button in the top right
Click on the Custom tax name field
Change the custom name
Save it
Navigate to the #admins room
Open the system messages thread
Log in to New Expensify
Create a new workspace (or use an existing one)
Go to Workspace Settings > Enabled Distance rates in more features
Go to Workspace Settings > Distance rates
Add a new distance rate (e.g., "Test Rate")
Disable the newly created rate by toggling it off
Go to the #admins room for this workspace
Open the thread for the system message
Verify that:
enabled the Distance rate "Test Rate"disabled the Distance rate "Test Rate"Screen.Recording.2025-12-26.at.9.44.41.PM.mov
Offline tests
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2025-12-26.at.9.44.41.PM.mov