feat: Add method to create thread to Bot#511
Merged
osovskiyalexandr merged 6 commits intomasterfrom Jul 31, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #511 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 125 126 +1
Lines 4381 4417 +36
=========================================
+ Hits 4381 4417 +36
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
7fb4baf to
8c898a0
Compare
88feb15 to
c7bd57b
Compare
c7bd57b to
7fe0eca
Compare
osovskiyalexandr
requested changes
Jun 26, 2025
Contributor
There was a problem hiding this comment.
thread_creation_setup стоит вынести в фикстуру
create_chat_succeed - тред же, а не чат
Ты покрыл кейс только с ThreadCreationError, в идеале надо проверить кейсы:
- status = "error"
- reason = None или отсутствует
- error_data = {}
Contributor
Author
There was a problem hiding this comment.
thread_creation_setup- это создание мокнутого эндпоинта?create_chat_suceed- понял, недогляделstatus="error"и пустойerror_dataведь проверяются, не до конца понимаю, что необходимо добавить
osovskiyalexandr
approved these changes
Jul 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
pyproject.tomlpybotxinbot-template