Skip to content

Added Mod Request System#10

Open
Guichaguri wants to merge 3 commits intoF32Organization:masterfrom
Guichaguri:master
Open

Added Mod Request System#10
Guichaguri wants to merge 3 commits intoF32Organization:masterfrom
Guichaguri:master

Conversation

@Guichaguri
Copy link
Copy Markdown
Contributor

This PR adds a mod request system.

Example

  • List of mods with an upvote button
  • Can only upvote one time per IP
  • Let you submit requests
  • Prevent invalid URLs or duplicated names/URLs
  • Messages for user feedback
  • Prevent XSS Injection

There are some reasons why I used JSON instead of a custom format:

  • In some cases: faster parsing
  • The values are better encoded
  • Less code
  • Compressed Data

To reset, just replace everything in the JSON to []. If you need a decompressed JSON to remove the values, just paste everything on JSON Formatter

@Guichaguri
Copy link
Copy Markdown
Contributor Author

I just fixed a security issue and added the sender's IP, the time (in unix timestamp) that the suggestion was sended and a limit of 3 suggestions per day for each IP. It should help prevent spamming.
After this PR, I'll create another one fixing some HTML deprecated/invalid tags.

Just tell me if I should add something else

@Guichaguri Guichaguri mentioned this pull request Sep 27, 2015
@steveowashere
Copy link
Copy Markdown

Looks exactly like what I had in mind. Really top notch work.

From what I can understand, the code looks good too.

@Guichaguri
Copy link
Copy Markdown
Contributor Author

Thanks. It's not the perfect solution, but it is fast, safe and it works

@fewizz
Copy link
Copy Markdown

fewizz commented Sep 27, 2015

👍

@Xen1290
Copy link
Copy Markdown

Xen1290 commented Nov 30, 2015

Very good, but you should resolve merge conflicts @Guichaguri
@DZCreeper

@Guichaguri
Copy link
Copy Markdown
Contributor Author

Everything fixed. @Xen1290 @DZCreeper

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants