Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes an issue in the dataconverter convert() flow where providing append via kwargs could incorrectly force append mode even when append=False, impacting both root attribute tagging and the HDF5 write mode.
Changes:
- Use
kwargs.get("append", False)to correctly propagate the boolean append value to root attributes. - Use
kwargs.get("append", False)to correctly propagate the boolean append value toWriter(..., append=...).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mkuehbach
approved these changes
Mar 17, 2026
Collaborator
mkuehbach
left a comment
mkuehbach
left a comment
There was a problem hiding this comment.
Good catch, please merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug: writes always append=True, if append comes in
kwargs.And uses the same syntax to get
appendfromkwargs.