Skip to content

Conversation

@Hawraa17
Copy link

@Hawraa17 Hawraa17 commented Nov 18, 2025

  • Created separate functions to calculate P and Q for better readability and reuse
  • No functional changes to solver logic
  • Condensed print statements (check if it is ok to print Analytical and Numerical values with only 6 floating points)

@Hawraa17 Hawraa17 changed the title Reorgnaized Post-processing - initial draft Reorgnaized demo_pml Post-processing - initial draft Nov 18, 2025
@Hawraa17 Hawraa17 changed the title Reorgnaized demo_pml Post-processing - initial draft Reorgnaized demo_pml Post-processing Nov 18, 2025
@Hawraa17 Hawraa17 changed the title Reorgnaized demo_pml Post-processing Reorganized demo_pml Post-processing Nov 18, 2025
@Hawraa17 Hawraa17 marked this pull request as draft November 19, 2025 21:27
@Hawraa17
Copy link
Author

Wanted to tag you both to review the work if you have any comments @jhale @jorgensd

@Hawraa17 Hawraa17 marked this pull request as ready for review November 22, 2025 00:50
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove these files

@jorgensd
Copy link
Member

@Hawraa17 : I had a look at your changes, and while doing that, i decided to rewrite some of the less explained components of the code: #4000

This change would separate P and Q into simple one-liners, as no marker or "averaging" is needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants