Remove constructor logging in DefaultRegistryClient#59
Merged
Conversation
This was causing a problem where the logger was being called before the calling superclass was initialized, leading to error: "Must call super constructor in derived class before accessing 'this' or returning from derived constructor"
cmoesel
approved these changes
Jun 30, 2025
Member
cmoesel
left a comment
cmoesel
left a comment
There was a problem hiding this comment.
For others who might be following this, we agreed that we don't need to log the custom registry since the log messages during package downloads show the custom registry URL (and since logging during class construction was causing problems).
Thanks for this PR, @bkaney. And thanks for the new test -- it's a great representation of the exact issue we were running into.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was causing a problem where the logger was being called before the calling superclass was initialized, leading to error: "Must call super constructor in derived class before accessing 'this' or returning from derived constructor"