Align $sqlquery-run parameters with CQL $evaluate pattern#321
Open
Align $sqlquery-run parameters with CQL $evaluate pattern#321
Conversation
Replace custom `parameter` (0..*) with parts {name, value} with a standard
nested `parameters: Parameters (0..1)` resource, following the CQL IG
Library/$evaluate operation pattern for passing arbitrary typed parameters
to a library by name.
Closes #318
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This was referenced Mar 3, 2026
Collaborator
|
This will need to be reconciled with #327 before merging. |
johngrimes
approved these changes
Mar 17, 2026
Collaborator
johngrimes
left a comment
There was a problem hiding this comment.
I think this looks good, but we should merge #327 first, then merge master back into this branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
parameter(0..*) with{name, value}parts with a standard nestedparameters: Parameters (0..1)resource$evaluateoperation pattern for passing arbitrary typed parameters to a library by nameMotivation
The previous
parameterinput with custompart[name, value]reinvented what the FHIRParametersresource already provides. The CQL$evaluateoperation — the closest analogy (both execute a Library with user-supplied typed parameters) — usesparameters: Parameters (0..1). See CQL IG source and CQL community discussion.Changes
input/fsh/operations.fsh— replacedparameter[4]definition (19 lines of parts → 4 lines withtype: Parameters)OperationDefinition-SQLQueryRun-intro.md— minor wording updateOperationDefinition-SQLQueryRun-notes.md— rewrote all HTTP examples, added "Parameter Passing" section with CQL referenceopenspec/changes/align-sqlquery-run-with-cql/Before / After
Before:
{ "name": "parameter", "part": [ { "name": "name", "valueString": "patient_id" }, { "name": "value", "valueString": "Patient/123" } ]}After:
{ "name": "parameters", "resource": { "resourceType": "Parameters", "parameter": [ { "name": "patient_id", "valueString": "Patient/123" }, { "name": "from_date", "valueDate": "2024-01-01" } ] }}Test plan
Closes #318
See also #320 (follow-up: GET parameter support)
🤖 Generated with Claude Code