Skip to content

Conversation

@oleanders
Copy link
Member

No description provided.

@oleanders oleanders requested a review from Copilot May 21, 2025 11:16
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR renames the Java package namespace from no.fint.model to no.novari.model and prepares the CI workflow for v4 by upgrading Java and GitHub Actions versions.

  • Refactored package declarations across all Fint* model interfaces and classes.
  • Removed unused imports in FintMainObject.java.
  • Updated .github/workflows/publish.yaml to use JDK 21 and bump action versions.

Reviewed Changes

Copilot reviewed 12 out of 14 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/main/java/no/novari/model/FintRelation.java Updated package declaration to no.novari.model.
src/main/java/no/novari/model/FintReference.java Updated package declaration to no.novari.model.
src/main/java/no/novari/model/FintObject.java Updated package declaration to no.novari.model.
src/main/java/no/novari/model/FintMultiplicity.java Updated package declaration to no.novari.model.
src/main/java/no/novari/model/FintModelObject.java Updated package declaration to no.novari.model.
src/main/java/no/novari/model/FintMainObject.java Updated package declaration and removed unused imports.
src/main/java/no/novari/model/FintIdentifikator.java Updated package declaration to no.novari.model.
src/main/java/no/novari/model/FintComplexDatatypeObject.java Updated package declaration to no.novari.model.
src/main/java/no/novari/model/FintAbstractObject.java Updated package declaration to no.novari.model.
.github/workflows/publish.yaml Bumped actions versions, switched to JDK 21.
Files not reviewed (2)
  • Jenkinsfile: Language not supported
  • gradle/wrapper/gradle-wrapper.properties: Language not supported
Comments suppressed due to low confidence (2)

.github/workflows/publish.yaml:19

  • The adopt distribution is deprecated in actions/setup-java@v4; update this to temurin to align with the action’s supported distributions.
            distribution: 'adopt'

src/main/java/no/novari/model/FintRelation.java:1

  • Renaming the package from no.fint.model to no.novari.model is a breaking change; ensure module declarations or documentation reflect this update and provide migration guidance for existing consumers.
package no.novari.model;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants