Skip to content

Conversation

@anlancs
Copy link
Contributor

@anlancs anlancs commented Dec 31, 2025

When vlan id of one interface (e.g. bond) is removed to be empty, zebra_vlan_mbr_re_eval is not called. It results in the existence of wrong members in the acc_bd->mbr_zifs.

When vlan id of one interface (e.g. bond) is removed to be empty,
`zebra_vlan_mbr_re_eval` is not called.  It results in the existence
of wrong members in the `acc_bd->mbr_zifs`.

Signed-off-by: anlan_cs <anlan_cs@126.com>
Copy link
Member

@ton31337 ton31337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Topotest?

@donaldsharp
Copy link
Member

Yeah I would like to have a better understanding of what sequence of events is causing this to happen?

@anlancs
Copy link
Contributor Author

anlancs commented Jan 6, 2026

No idea for topo. @ton31337
"ip link add x type bond; ip link set dev x master bridge0; bridge vlan del vid 1 dev x;"
But this x interface is still in in the acc_bd (1) 's mbr_zifs list. @donaldsharp

Copy link
Member

@riw777 riw777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good ... no idea on whether this could have a topotest or not (?)

@anlancs anlancs requested a review from ton31337 January 7, 2026 18:53
@ton31337 ton31337 requested a review from donaldsharp January 7, 2026 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants