Skip to content

Add fabric.svg#185

Open
teunjojo wants to merge 5 commits intoFabricMC:mainfrom
teunjojo:patch-1
Open

Add fabric.svg#185
teunjojo wants to merge 5 commits intoFabricMC:mainfrom
teunjojo:patch-1

Conversation

@teunjojo
Copy link

Copied from comment on pull request #101 because original author is not responding. #101 (comment)

teunjojo and others added 2 commits July 24, 2025 15:39
Copied from comment on pull request FabricMC#101 because original author is not responding.
FabricMC#101 (comment)

Co-authored-by: solonovamax <solonovamax@12oclockpoint.com>
Copy link
Contributor

@haykam821 haykam821 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This version of the icon appears different from the original icon.

@teunjojo
Copy link
Author

teunjojo commented Jul 24, 2025

You are right, I had not noticed that as I just copied it, but I fixed it myself.
It should be the same now.

@teunjojo
Copy link
Author

teunjojo commented Jul 24, 2025

Wait, I just noticed the view size is different. Don't know how much that matters tho.

EDIT: nevermind I was looking at the wrong png. It was fine before :p

@solonovamax
Copy link

solonovamax commented Sep 15, 2025

on the height + width + viewbox change:

I made those paths match the fabric.png image as accurately as possible, which also has a bunch of whitespace around it.

if you wanted to adjust the viewbox, the best way to do it would be to go and modify the svg's paths to shift them over (which honestly is best done by hand, the times I've tried to resize/move an svg in inkscape, it has been kinda annoying, as inkscape will apply a bunch of transforms and you then need to flatten them) and then adjust the width/height down without messing with the viewbox.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments