Add .NET 9 targets, etc. #107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use latest System.Text.Json for fixed deep clone.
There was a problem hiding this comment.
Copilot reviewed 61 out of 70 changed files in this pull request and generated 1 comment.
Files not reviewed (9)
- Directory.Build.props: Language not supported
- Directory.Packages.props: Language not supported
- FacilityCSharp.sln: Language not supported
- global.json: Language not supported
- src/Facility.CodeGen.CSharp/Facility.CodeGen.CSharp.csproj: Language not supported
- src/Facility.ConformanceApi/Facility.ConformanceApi.csproj: Language not supported
- src/Facility.Core.Assertions/Facility.Core.Assertions.csproj: Language not supported
- src/Facility.Core.MessagePack/Facility.Core.MessagePack.csproj: Language not supported
- src/Facility.Core/Facility.Core.csproj: Language not supported
Comments suppressed due to low confidence (1)
src/Facility.Core.MessagePack/MessagePackServiceSerializer.cs:79
- Using MemoryStream.TryGetBuffer without ensuring that the underlying buffer is publicly visible may lead to issues. Consider initializing the MemoryStream using a constructor that enables a publicly visible buffer or use an alternative method to retrieve the buffer safely.
stream1.TryGetBuffer(out var buffer1);
| if (type != value2.GetType()) | ||
| return false; | ||
|
|
||
| return ToJson(value1) == ToJson(value2); |
There was a problem hiding this comment.
Using string equality for comparing JSON serialized representations can be sensitive to formatting and ordering differences. Consider using a structured JSON comparator such as JToken.DeepEquals to improve reliability.
ddunkin
reviewed
Apr 10, 2025
| /// <summary> | ||
| /// Deep clones the DTO. | ||
| /// </summary> | ||
| public virtual T DeepClone() => JsonSerializer.Clone((T) this); |
Contributor
There was a problem hiding this comment.
Worth a mention in the release notes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.