Allow for request scoped service instances in fastify plugin.#71
Merged
mitchknife merged 6 commits intoFacilityApi:masterfrom Feb 12, 2025
Merged
Allow for request scoped service instances in fastify plugin.#71mitchknife merged 6 commits intoFacilityApi:masterfrom
mitchknife merged 6 commits intoFacilityApi:masterfrom
Conversation
mitchknife
changed the title
mitchknife
changed the title
mitchknife
force-pushed
the
fastify-fixes
branch
from
9bcbd03 to
096e325
Compare
Contributor
No need, thanks for asking. |
These errors were introduced with FacilityApi#69
After I've tested this in the wild a bit, I'll remove this and open it up for additional usage in case the folks over at Logos want to start using fastify for some servery things.
mitchknife
force-pushed
the
fastify-fixes
branch
from
5b4eae0 to
72dc29d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is "technically" a breaking change, but I'm almost certain no one is using this code yet (including myself). Should I bump the major version just in case? cc @ejball?