Draft
Conversation
- run.bat: sets up Python (downloads embeddable if needed), installs
dependencies into a venv or embedded Python, and runs main.py.
Subsequent runs skip setup and start immediately.
Fixes vs initial version:
- Fast path now requires setup marker for both venv and embed paths,
so a failed mid-setup run doesn't skip to launch with missing deps
- Check errorlevel after get-pip.py execution
- Quote BASE_PYTHON and VENV_DIR in venv creation command
- Detect ARM64 vs amd64 for correct embeddable download URL
- Quote SETUP_MARKER in echo redirect
- README: replace duplicated install instructions with a link to the
main FactorioAccess repo README as the single source of truth.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
LevFendi
added
documentation
uv manages Python version installation and venv creation itself, replacing the embeddable Python download, .pth editing, and get-pip bootstrap with a single binary. ARM64 detection is still needed for the uv binary itself. Removes --force-embed flag (no longer applicable with uv). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Unescaped ) was closing the if block prematurely, causing 'may was unexpected at this time' error. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- build_main.py: add --setup-only flag that exits after venv creation and dep install, before re-invoking itself to run PyInstaller - run.bat: drop independent venv/pip logic; call build_main.py --setup-only instead. uv is retained as a fallback to download Python 3.11 if not found on PATH, with the executable path then passed to build_main.py. Venv dir aligned to ./venv to match build_main.py. Verify venv exists after setup since build_main.py does not propagate pip errors as a non-zero exit code. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
build_main.py uses os.system() without checking pip's return code, so a failed playsound install (git dep) went undetected. Now we import playsound to verify, and if missing we wipe the venv so the next run retries setup rather than hitting the fast path with missing deps. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.