Keep dynamically added model receivers at the end when unmuting signals

[shosca]

Receiver order is somewhat important and packages like django-dirtyfields adds receivers dynamically where it can reset the model state. This change restores the original receivers first then appends the dynamically added receivers.

[kingbuzzman]

I’m having a hard time understanding your use case, can you write a test that tests this functionality?

edit: from what i can gather about the package, it attaches itself on __init__ on a signal to the main instance and all the relationships of the instance in order to maintain the state. I understand your use case now. Nevertheless a test that proves this works is vital. Also i’m not entirely sure this needs to be in this package, but that’s up to the members to decide really.

[shosca]

can you write a test that tests this functionality?

extended the existing test case

i’m not entirely sure this needs to be in this package, but that’s up to the members to decide really.

Yup, though I think it belongs here since mute_signals is the one touching the signal receivers and should be able to restore signal receivers as close to the original as possible

[rbarrois]

Hey! This looks like a "misfeature" indeed, thanks for the improvement suggestion.

I'll have to dig deeper into the suggested code though, it's not very easy to understand at first sight — and, since this is a seldom touched part of the code, I'll need to be extra sure I understand it in order to avoid breaking the feature later ;)