chore(CI): clean up semantic-release setup#142
Merged
emmclaughlin merged 1 commit intomainfrom Jan 30, 2026
Merged
Conversation
awaterston01
approved these changes
Jan 30, 2026
| fs.writeFileSync(destination, file.toString().replace(/dist\//g, "")); | ||
| const packageJson = JSON.parse(file.toString().replace(/dist\//g, "")); | ||
|
|
||
| // Remove fields that shouldn't be in the published package |
There was a problem hiding this comment.
I will trust you that we should really be deleting all these...
For my understanding though, what's the goal here? Trying to put out a new release and the old release method is out of date so need to update?
Collaborator
Author
There was a problem hiding this comment.
Yes, we used to use an NPM token but NPM deprecated using those for releases. Trying to move to the new method, but finding some issues with our original setup that is blocking. E.g. I think we should have always been removing these fields from the dist version of the package.json so they are not relevant to the final build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.