Open
Conversation
| #[test] | ||
| fn test_sign_and_verify() { | ||
| let key_manager = create_key_manager("test_output/rsa_sign_verify", None).unwrap(); | ||
| let pem = key_manager.generate_rsa_keypair(&mut thread_rng()).unwrap(); |
Contributor
There was a problem hiding this comment.
I’d suggest renaming pem ((Privacy-Enhanced Mail)) to pubkey_pem for readability.
The method name generate_rsa_keypair suggests it returns a full keypair, so calling the result pem can be misleading to readers who aren’t familiar with the KeyManager API. Using pubkey_pem makes the intent explicit when verifying the signature.
the same apply for all the tests
Author
There was a problem hiding this comment.
Thank you! will do the changes!
danielemiliogarcia
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
##Summary
Adds 6 integration tests for RSA sign/verify, encrypt/decrypt, and error handling.
##Changes
New Tests (6)
##New file: src/tests/rsa_test.rs Modified: src/tests/mod.rs (registered new module)