Skip to content

Added fairmint / canton env variables prod deploy script#169

Merged
thibauld merged 1 commit intodevfrom
thibauld/prod-env-var
Jun 12, 2025
Merged

Added fairmint / canton env variables prod deploy script#169
thibauld merged 1 commit intodevfrom
thibauld/prod-env-var

Conversation

@thibauld
Copy link
Collaborator

What?

Please describe what you're trying to accomplish in this PR.

Why?

What problem does this solve? Why is this important? What's the context?

Screenshots (optional)

@thibauld thibauld merged commit 65d14c5 into dev Jun 12, 2025
2 checks passed
@thibauld thibauld deleted the thibauld/prod-env-var branch June 12, 2025 22:45
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: GitHub Secrets Not Passed to Docker Containers

The three new secrets (FAIRMINT_MAINNET_USER_ID, FAIRMINT_MAINNET_PARTY_ID, TRANSFER_AGENT_MAINNET_CLIENT_SECRET) are added to the GitHub Actions step environment. However, they are not propagated to the Docker application container via the docker run -e command. Consequently, the application will lack these required environment variables, leading to runtime failures for dependent code and preventing the intended feature from working.

.github/workflows/deploy.prod.yaml#L57-L60

RPC_URL: ${{ secrets.RPC_URL }}
FAIRMINT_MAINNET_USER_ID: ${{ secrets.FAIRMINT_MAINNET_USER_ID }}
FAIRMINT_MAINNET_PARTY_ID: ${{ secrets.FAIRMINT_MAINNET_PARTY_ID }}
TRANSFER_AGENT_MAINNET_CLIENT_SECRET: ${{ secrets.TRANSFER_AGENT_MAINNET_CLIENT_SECRET }}

Fix in Cursor


Was this report helpful? Give feedback by reacting with 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant