Conversation
Added fairmint / canton env variables prod deploy script
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Bug: GitHub Secrets Not Forwarded to Docker
Three new secrets (FAIRMINT_MAINNET_USER_ID, FAIRMINT_MAINNET_PARTY_ID, TRANSFER_AGENT_MAINNET_CLIENT_SECRET) are added to the GitHub Actions job environment but are not forwarded to the Docker container via -e flags in the docker run command. Consequently, the application inside the container will not receive these required configuration values, leading to runtime failures or incorrect behavior.
.github/workflows/deploy.prod.yaml#L57-L60
open-captable-protocol/.github/workflows/deploy.prod.yaml
Lines 57 to 60 in 65d14c5
Was this report helpful? Give feedback by reacting with 👍 or 👎
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Please describe what you're trying to accomplish in this PR.
Why?
What problem does this solve? Why is this important? What's the context?
Screenshots (optional)