fix(UniqueGenerator): prevent memory exhaustion when chaining unique()->optional() #1029
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…)->optional() When calling unique()->optional()->method(), the __call handler would serialize the returned ChanceGenerator object (which contains the entire Generator with all providers) rather than the final value. This caused exponential memory growth. Adding explicit optional() and valid() methods ensures proper generator chaining - ChanceGenerator now wraps UniqueGenerator, delegating back for actual value generation while preserving uniqueness tracking. Fixes FakerPHP#1027
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes memory exhaustion when using
unique()->optional()->method()orunique()->valid()->method()chains by adding explicitoptional()andvalid()methods toUniqueGenerator.This is the 2.0 branch counterpart to #1028.
When calling
$faker->unique()->optional()->safeEmail(), theUniqueGenerator::__call()handler would calloptional()on the underlying generator, returning aChanceGenerator, then attempt toserialize()it for uniqueness tracking. TheChanceGeneratorcontains a reference to the entireGeneratorwith all providers, causing massive serialized strings and exponential memory growth.By adding explicit
optional()andvalid()methods toUniqueGenerator,ChanceGeneratornow wrapsUniqueGenerator(not the baseGenerator). When the final method is called, it delegates back toUniqueGenerator, which serializes only the final value (e.g., the email string), not generator objects.Fixes #1027