feat(Base): support float probability in boolean() #1032
+12
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous implementation used integer comparison (1-100) which limited probability resolution to 1%. Using float comparison with 53 bits of precision allows for sub-percentage probability values. Fixes FakerPHP#761
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
boolean()now accepts float probabilities, so you can doboolean(0.001)for a 0.1% chance instead of being limited to integer percentages.Uses 53-bit float generation (equivalent to PHP 8.3's
Randomizer::nextFloat()). Backward compatible — integer percentages still work.Fixes #761