More chat patterns (timestamp and log), take 2 by SaphireLattice · Pull Request #49 · FallingColors/MoreIotas

SaphireLattice · 2025-10-03T23:50:14Z

Now directing it to main, and added Forge!

Uh, I've not tested if it even builds, Gradle decided to be shit to me. So I need some help here, whee.. :'D

…em too Also fixes a Fabric-only bug where global messages get recorded only when someone doesn't have a prefix set up

object-Object · 2025-10-05T04:42:36Z

The build seems to be failing.

SaphireLattice · 2025-10-06T16:20:05Z

On one hand, it ended up with a bunch of issues due to writing this blindly without building. On another, it was not that bad?

For some reason getServerLevel() kept nagging me to use try-with-resources and something about AutoCloseable and I'm not sure what's up with that. Is it for marking "hey there's something working with the level, don't discard it yet" or what?

object-Object · 2025-10-07T00:14:03Z

Common/src/main/resources/assets/moreiotas/lang/en_us.json

  "moreiotas.page.strings.string/chat/caster": "Adds the last message the caster sent to the stack as a string.",
  "moreiotas.page.strings.string/chat/all": "Adds the last message anyone sent to the stack as a string.",
+  "moreiotas.page.strings.string/chat/timestamp/caster": "Returns the time in 20ths of a second since the world's beginning, to when the caster sent the last message. Though sometimes it just gives back a zero...",
+  "moreiotas.page.strings.string/chat/timestamp/all": "Similar to $(l:moreiotas:patterns/strings#moreiotas:string/chat/timestamp/caster)$(action)Sandglass' Reflection/$, but tells when anyone sent a message for all to hear. Oddly, returns a count under that too. But it's not like two people would speak at the same single instant, right?",


Suggested change

"moreiotas.page.strings.string/chat/timestamp/all": "Similar to $(l:moreiotas:patterns/strings#moreiotas:string/chat/timestamp/caster)$(action)Sandglass' Reflection/$, but tells when anyone sent a message for all to hear. Oddly, returns a count under that too. But it's not like two people would speak at the same single instant, right?",

"moreiotas.page.strings.string/chat/timestamp/all": "Similar to $(l:patterns/strings#moreiotas:string/chat/timestamp/caster)$(action)Sandglass' Reflection/$, but tells when anyone sent a message for all to hear. Oddly, returns a count under that too. But it's not like two people would speak at the same single instant, right?",

object-Object

Left several comments with specific changes that need to be made, as well as some questions and higher-level concerns.

object-Object · 2025-10-07T00:22:25Z

Common/src/main/java/ram/talia/moreiotas/api/mod/MoreIotasConfig.kt

+            const val DEFAULT_MAX_CHAT_LOG = 341 // 3 within 1024
+            const val MIN_MAX_CHAT_LOG: Int = 0
+            const val MAX_MAX_CHAT_LOG: Int = 341 // TODO: take into account the stack size config...


This feels like a really weirdly specific default. What about something like 256 instead? Or 64 might be a more reasonably balanced value.

object-Object · 2025-10-07T00:26:06Z

Common/src/main/java/ram/talia/moreiotas/common/casting/actions/strings/OpChatTimestamp.kt

+
+    override fun execute(args: List<Iota>, env: CastingEnvironment): List<Iota> {
+        if (!allChat)
+            return IXplatAbstractions.INSTANCE.lastMessageTimestamp(env.castingEntity as? Player).asActionResult


Nit: this should either be on the same line as the if, or it should be wrapped in {} for clarity.

object-Object · 2025-10-07T00:26:34Z

Common/src/main/java/ram/talia/moreiotas/common/casting/actions/strings/OpChatTimestamp.kt

+    override fun execute(args: List<Iota>, env: CastingEnvironment): List<Iota> {
+        if (!allChat)
+            return IXplatAbstractions.INSTANCE.lastMessageTimestamp(env.castingEntity as? Player).asActionResult
+        return listOf<Iota>(


Nit: is the type required here?

object-Object · 2025-10-07T00:27:34Z

...n/resources/assets/hexcasting/patchouli_books/thehexbook/en_us/entries/patterns/strings.json

+    {
+      "type": "hexcasting:pattern",
+      "op_id": "moreiotas:string/chat/timestamp/caster",
+      "anchor": "moreiotas:string/chat/timestamp/caster",
+      "input": "",
+      "output": "str",
+      "text": "moreiotas.page.strings.string/chat/timestamp/caster"
+    },
+    {
+      "type": "hexcasting:pattern",
+      "op_id": "moreiotas:string/chat/timestamp/all",
+      "anchor": "moreiotas:string/chat/timestamp/all",
+      "input": "",
+      "output": "str",
+      "text": "moreiotas.page.strings.string/chat/timestamp/all"
+    },
+    {
+      "type": "hexcasting:pattern",
+      "op_id": "moreiotas:string/chat/log/all",
+      "anchor": "moreiotas:string/chat/log/all",
+      "input": "",
+      "output": "str",
+      "text": "moreiotas.page.strings.string/chat/log/all"
+    },


The input/output needs to be updated for all of these.

object-Object · 2025-10-07T00:28:36Z

Common/src/main/resources/assets/moreiotas/lang/en_us.json

  "hexcasting.action.moreiotas:string/chat/all": "Listener's Reflection",
+  "hexcasting.action.moreiotas:string/chat/timestamp/caster": "Sandglass' Reflection",
+  "hexcasting.action.moreiotas:string/chat/timestamp/all": "Clocktower's Reflection",
+  "hexcasting.action.moreiotas:string/chat/log/all": "Stenographer's Reflection",


It's not a reflection if it pops values from the stack.

object-Object · 2025-10-07T00:57:46Z

Fabric/src/main/java/ram/talia/moreiotas/fabric/eventhandlers/ChatEventHandler.kt


-        if (!text.startsWith(prefix))
+        // Just in case! People configure stuff in the weirdest ways
+        if (server.maxChatLog == 0)


What happens if it's less than 0?

object-Object · 2025-10-07T00:59:34Z

Fabric/src/main/java/ram/talia/moreiotas/fabric/eventhandlers/ChatEventHandler.kt

+        while (messageLog.isNotEmpty() && messageLog.size > server.maxChatLog) {
+            // Just in case somehow we end up putting two "at once" even though this is only place this is touched
+            messageLog.removeFirst()
+        }
+
+        messageLog.addLast(ChatEntry(text, timestamp, player.name.string))


If messageLog.size >= server.maxChatLog at the start, then this code results in messageLog containing server.maxChatLog + 1 entries. I think the loop condition should be >= instead of > to fix this.

object-Object · 2025-10-07T01:16:25Z

Common/src/main/java/ram/talia/moreiotas/common/casting/actions/strings/OpChatLog.kt

After discussing this on Discord, I think this pattern should be changed to pop nothing from the stack and push a list of lists, where each inner list is [message, username]. The list should contain all public chat messages that were sent in the most recent tick where at least one user sent a chat message.

For example:

If no chat messages have been sent since the server started: []

If the most recent chat message was sent by object_Object, and only one message was sent that tick: [["message contents", "object_Object"]]

If both object_Object and chloetax sent a message 1 second ago: [["message 1", "object_Object"], ["message 2", "chloetax"]]

object-Object · 2025-10-07T01:20:52Z

Fabric/src/main/java/ram/talia/moreiotas/fabric/eventhandlers/ChatEventHandler.kt

Could you add some comments to this and the Forge equivalent to clarify the control flow and what happens in each case? (eg. sender doesn't have a prefix set, sender has a prefix set but the message doesn't start with it, sender has a prefix and the message starts with it)

object-Object · 2025-10-07T01:22:29Z

Fabric/src/main/java/ram/talia/moreiotas/fabric/eventhandlers/ChatEventHandler.kt

        if (prefix == null) {
            lastMessages[player.uuid] = text
-            lastMessage = text
-            return true


Why was this removed?

object-Object · 2025-10-07T01:25:34Z

Also, the build is still failing. Have you tested this locally at all?

SaphireLattice added 4 commits October 4, 2025 06:24

Implement untested actions for dealing with chat timestamp, record th…

65fff76

…em too Also fixes a Fabric-only bug where global messages get recorded only when someone doesn't have a prefix set up

Add untested chatlog, make a mess of Kotlin and Java lists

dc9bece

Build, test and fix bunch of little things about chat timestamps, log

de6d75f

Forge implementation for chat history/timestamps

7198eb7

SaphireLattice force-pushed the feature/more-chat-patterns branch from 3b18c3b to 7198eb7 Compare October 4, 2025 00:32

Actually make it build, reverse fabric chat log

2a3afe8

object-Object reviewed Oct 7, 2025

View reviewed changes

object-Object requested changes Oct 7, 2025

View reviewed changes

	"moreiotas.page.strings.string/chat/timestamp/all": "Similar to $(l:moreiotas:patterns/strings#moreiotas:string/chat/timestamp/caster)$(action)Sandglass' Reflection/$, but tells when anyone sent a message for all to hear. Oddly, returns a count under that too. But it's not like two people would speak at the same single instant, right?",
	"moreiotas.page.strings.string/chat/timestamp/all": "Similar to $(l:patterns/strings#moreiotas:string/chat/timestamp/caster)$(action)Sandglass' Reflection/$, but tells when anyone sent a message for all to hear. Oddly, returns a count under that too. But it's not like two people would speak at the same single instant, right?",

Conversation

SaphireLattice commented Oct 3, 2025

Uh oh!

object-Object commented Oct 5, 2025

Uh oh!

SaphireLattice commented Oct 6, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

object-Object left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

object-Object commented Oct 7, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants