Fix patternmaster's throwing for any non-static pattern#59
Open
beholderface wants to merge 1 commit intoFallingColors:mainfrom
Open
Fix patternmaster's throwing for any non-static pattern#59beholderface wants to merge 1 commit intoFallingColors:mainfrom
beholderface wants to merge 1 commit intoFallingColors:mainfrom
Conversation
Currently, the only spot in the `matchPattern` method where that boolean is actually used, it just immediately throws if it's true. Should probably address that in base hex at some point, but I have no idea what it's supposed to do there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the only spot in the
matchPatternmethod where that boolean is actually used just immediately throws if it's true. Should probably address that in base hex at some point, but I have no idea what it's supposed to do.This change does mean that you can use patternmaster's for a great spell brute-forcer without having to handle mishaps, but I don't think that's something we need to worry about.