Small fix when calling response.throttled#63
Open
richardkmiller wants to merge 1 commit intoFamilySearch:masterfrom
Open
Small fix when calling response.throttled#63richardkmiller wants to merge 1 commit intoFamilySearch:masterfrom
response.throttled#63richardkmiller wants to merge 1 commit intoFamilySearch:masterfrom
Conversation
…ttled` can result in "Cannot set properties of undefined (setting 'throttled')"
Contributor
|
Thanks for the PR, I no longer have access to this repo lol. Someone else will have to merge it. |
Author
|
Ha no problem! And if someone wants to merge the PR, no hurry on my part. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey @misbach! Here's a fix for a small thing I saw in production. While throttling, if no response is given, the call to
response.throttledcan result in "Cannot set properties of undefined (setting 'throttled')".