Skip to content

Conversation

@wdconinc
Copy link

@wdconinc wdconinc commented Nov 30, 2025

With the m4 directory removed (#76), the AC_CONFIG_MACRO_DIR results in an error.

     8     autoreconf: export WARNINGS=
     9     autoreconf: Entering directory '.'
     10    autoreconf: configure.ac: not using Gettext
     11    autoreconf: running: aclocal -I /home/software/spack/__spack_path_pl
           aceholder__/__spack_path_placeholder__/__spack_path_placeholder__/__
           spack_path_placeholder__/__spack_path_placeholder__/__spack_path_pla
           ceholder__/__spack_path_placeholder__/__spack_path_placeholder__/__s
           pack_path_placeh/linux-x86_64_v3/libtool-2.4.7-pkrzmj3exucbqdwkqidyc
           6czgjmbz4hs/share/aclocal -I /usr/share/aclocal --force -I m4
  >> 12    aclocal: error: couldn't open directory 'm4': No such file or direct
           ory
  >> 13    autoreconf: error: aclocal failed with exit status: 1

Ref: https://gitlab.spack.io/spack/spack-packages/-/jobs/19061060

Copilot AI review requested due to automatic review settings November 30, 2025 22:13
Copilot finished reviewing on behalf of wdconinc November 30, 2025 22:15
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a build failure caused by the removal of the m4 directory in PR #76. The AC_CONFIG_MACRO_DIR([m4]) directive in configure.ac was referencing a non-existent directory, causing autoreconf to fail with an aclocal error. The fix removes this directive, allowing the build configuration to proceed successfully.

Key Changes:

  • Removed the AC_CONFIG_MACRO_DIR([m4]) directive from configure.ac

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: Wouter Deconinck <wdconinc@gmail.com>
@wdconinc
Copy link
Author

FYI @mcarbonneaux

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant