refactor: remove unused receive() function in Escrow.sol#512
Open
huahuayu wants to merge 1 commit intoFastLane-Labs:mainfrom
Open
refactor: remove unused receive() function in Escrow.sol#512huahuayu wants to merge 1 commit intoFastLane-Labs:mainfrom
huahuayu wants to merge 1 commit intoFastLane-Labs:mainfrom
Conversation
huahuayu
force-pushed
the
fix/remove-receive-escrow
branch
from
c52167b to
2c6303e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in issue #506, the function in does not serve any purpose since legitimate fund transfers to Atlas are sent via payable function calls. Removing it reduces the risk of user funds being lost when accidentally sent to the contract address without data. This change helps prevent accidental ETH transfers that wouldn't be credited as atlETH.