Open
Conversation
BenSparksCode
approved these changes
Feb 28, 2024
Contributor
BenSparksCode
left a comment
BenSparksCode
left a comment
There was a problem hiding this comment.
LGTM as well!
I've just changed the VALIDATOR_SHARE_BASE and STAKE_RATIO constants to use uint256 instead of uint24. We save a little bit of gas this way because we don't need to convert to uint256 for the math, and there's also no benefit in using smaller vars as they each get stored in their own 32 bytes slots as constants anyway.
Changing to uint256 for those constants makes submitFlashBid and submitFlashBidWithRefund functions a little bit cheaper and makes the contract slightly smaller.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.