Applied clipping to canvas area from parent window#53
Applied clipping to canvas area from parent window#53R3sid3ntD1023 wants to merge 7 commits intoFattorino:masterfrom
Conversation
R3sid3ntD1023
force-pushed
the
master
branch
3 times, most recently
from
0126953 to
950eb21
Compare
|
Okay, how can I test your PR? (the clipping thing) Do you have a screenshot with before/after ? |
|
@arabine when scrolling the window and the window has a menubar the canvas would appear on top of the menu without using the main window as a clip rect , screenshot is after applying change |
… template argument, added dragdroptarget callback
|
@arabine the selection rect for nodes will be in another pull request |
|
Thanks for all the support. Right now it's an extremely busy period for me. But know that nothing will be lost and I'll do my best to review and merge everything as soon as possible |
|
Apologizes for disappearing for so long, I don't remember, is this PR ready for merge on your side? Or were you planning to add more? |
|
It’s ready
…On Sun, Oct 5, 2025 at 5:20 AM Gabriele Torelli ***@***.***> wrote:
*Fattorino* left a comment (Fattorino/ImNodeFlow#53)
<#53 (comment)>
Apologizes for disappearing for so long, I don't remember, is this PR
ready for merge on your side? Or were you planning to add more?
—
Reply to this email directly, view it on GitHub
<#53 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BJBM4NSJYJTB3CIUZKFYEN33WDPHBAVCNFSM6AAAAACCKNJTB6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTGNRYHA4TAMBUHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Why did you close the PR? |
|
Whoops didn't know i did |
|
Does this stop nodes from being rendered if outside the view area? |
|
yes |
Removed duplicate compile definition for IMGUI_DEFINE_MATH_OPERATORS.
3 participants
Also added a add node function that takes a shared_ptr to a node instead of template param, added dragdroptarget callback to allow drag dropping of nodes