feat: add timeline and event nodes #109
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umbobabo
commented
Sep 22, 2025
README.md
Outdated
| ### Timeline | ||
|
|
||
| ```ts | ||
| type TimelineLayoutWidth = Extract<LayoutWidth, "full-width" | "inset-left"> |
There was a problem hiding this comment.
@todor-videv1 I would like to avoid the empty string here, we can perhaps fix old content with the full-width value and keep this strict.
umbobabo
force-pushed
the
CI-3097
branch
2 times, most recently
from
7943d0e to
d0fcdee
Compare
umbobabo
commented
Oct 14, 2025
content-tree.d.ts
Outdated
| } | ||
| interface TimelineEvent extends Parent { | ||
| type: "timeline-event"; | ||
| dateLabel: string; |
There was a problem hiding this comment.
Agreed with @adgad
Suggested change
| dateLabel: string; | |
| title: string; |
umbobabo
commented
Oct 14, 2025
content-tree.d.ts
Outdated
| interface TimelineEvent extends Parent { | ||
| type: "timeline-event"; | ||
| dateLabel: string; | ||
| children: Paragraph[]; |
There was a problem hiding this comment.
Agreed with @adgad to support ImageSet as child here
There was a problem hiding this comment.
https://www.ft.com/content/2d627e4c-7f0b-4d39-9495-d704faffbf39 example with images in a timeline
umbobabo
commented
Oct 17, 2025
| type: "timeline-event" | ||
| /** The title of the event */ | ||
| title: string | ||
| children: (Paragraph | ImageSet)[] |
There was a problem hiding this comment.
@adgad @nadiasuleyman @todor-videv1 This would be more accurate. Same for L783
Suggested change
| children: (Paragraph | ImageSet)[] | |
| /** At least one Paragraph or one ImageSet should be provided **/ | |
| children: [Paragraph | ImageSet, ...(Paragraph | ImageSet)[]]; |
| title: string | ||
| /** The layout width for the timeline */ | ||
| layoutWidth: TimelineLayoutWidth | ||
| children: TimelineEvent[] |
There was a problem hiding this comment.
See below comment
Suggested change
| children: TimelineEvent[] | |
| /** Must contain at least one TimelineEvent */ | |
| children: [TimelineEvent, ...TimelineEvent[]]; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a timeline and timeline-event nodes so we can move timeline name out of the Layout node. We want to move away from experimental tags that requires to discontinue the usage of Layouts from the bodyXML.