Skip to content

add timeline section to content-tree Go representation #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 29, 2025
Merged

add timeline section to content-tree Go representation #119

merged 1 commit into from
Oct 29, 2025
+287 −1

Conversation

@lokendersinghft
Copy link
Contributor

@lokendersinghft lokendersinghft commented Oct 28, 2025 •
edited
Loading

This PR introduces the timeline section to the Go representation of the content-tree.
The bodyXML-to-content-tree Go transformer has been updated to support this new element.

  • The transformer expects the following structure:
  • The data-type attribute must have the value timeline when representing a timeline element.
  • The ol element must have the data-type attribute set to timeline_events.
  • Each li element within the list must have the data-type attribute set to timeline_event.

JIRA --> https://financialtimes.atlassian.net/browse/UPPSF-6510

@lokendersinghft lokendersinghft marked this pull request as ready for review October 28, 2025 07:54
@lokendersinghft lokendersinghft requested review from a team as code owners October 28, 2025 07:54
@lokendersinghft lokendersinghft requested a review from a team October 29, 2025 07:58
epavlova
epavlova approved these changes Oct 29, 2025
View reviewed changes
Copy link
Contributor

@epavlova epavlova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, my only thought is that we need to double check this when the JSON schemas are committed.

@epavlova epavlova requested a review from a team October 29, 2025 08:00
@lokendersinghft lokendersinghft merged commit af7397a into main Oct 29, 2025
2 checks passed
@lokendersinghft lokendersinghft deleted the feature/UPPSF-6510 branch October 29, 2025 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@epavlova epavlova epavlova approved these changes

@vlasakievft vlasakievft vlasakievft approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lokendersinghft @epavlova @vlasakievft