-
Notifications
You must be signed in to change notification settings - Fork 0
Created first model of the string art generator #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a first model of a string art generator by creating a 3D CAD model structure and adjusting configuration parameters for the number of nails. The changes establish the foundational components for a string art machine that can automatically create string art patterns.
Key changes include:
- Addition of 3D models for string art machine components (nail board, motor mount, fabric feeder)
- Integration with external libraries for mechanical components (sprockets, MCAD)
- Adjustment of minimum nail count configuration for the string art generator
Reviewed Changes
Copilot reviewed 63 out of 65 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| string-art-website/src/features/3RenderImage/components/StringArtConfig/StringArtConfigSection.tsx | Reduces minimum nail count from 360 to 180 |
| string-art-model/models/nailBoard.scad | Defines 3D model for circular nail board with configurable nail placement |
| string-art-model/models/motorMount.scad | Creates motor mount component with axle hole and fabric pole |
| string-art-model/models/fabricFeeder.scad | Implements fabric feeding mechanism with sprocket gears and stepper motor |
| string-art-model/main.scad | Main assembly file combining all components with proper positioning |
| string-art-model/main.json | Configuration file for the 3D model parameters |
| string-art-model/libraries/* | External library dependencies for sprockets and mechanical components |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| axel_tranlation_x = (fabric_arm_width+10); | ||
| color("silver") | ||
| translate([-axel_tranlation_x,0,translation_z]) | ||
| rotate([0,90,0]) | ||
| cylinder(h = axel_tranlation_x*2, r = fabric_arm_axel_radius, $fn=100); |
Copilot
AI
Sep 18, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Variable name has a typo: 'axel_tranlation_x' should be 'axel_translation_x' (missing 's' in 'translation').
| axel_tranlation_x = (fabric_arm_width+10); | |
| color("silver") | |
| translate([-axel_tranlation_x,0,translation_z]) | |
| rotate([0,90,0]) | |
| cylinder(h = axel_tranlation_x*2, r = fabric_arm_axel_radius, $fn=100); | |
| axel_translation_x = (fabric_arm_width+10); | |
| color("silver") | |
| translate([-axel_translation_x,0,translation_z]) | |
| rotate([0,90,0]) | |
| cylinder(h = axel_translation_x*2, r = fabric_arm_axel_radius, $fn=100); |
| axel_tranlation_x = (fabric_arm_width+10); | ||
| color("silver") | ||
| translate([-axel_tranlation_x,0,translation_z]) | ||
| rotate([0,90,0]) | ||
| cylinder(h = axel_tranlation_x*2, r = fabric_arm_axel_radius, $fn=100); |
Copilot
AI
Sep 18, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Variable name has a typo: 'axel_tranlation_x' should be 'axel_translation_x' (missing 's' in 'translation').
| axel_tranlation_x = (fabric_arm_width+10); | |
| color("silver") | |
| translate([-axel_tranlation_x,0,translation_z]) | |
| rotate([0,90,0]) | |
| cylinder(h = axel_tranlation_x*2, r = fabric_arm_axel_radius, $fn=100); | |
| axel_translation_x = (fabric_arm_width+10); | |
| color("silver") | |
| translate([-axel_translation_x,0,translation_z]) | |
| rotate([0,90,0]) | |
| cylinder(h = axel_translation_x*2, r = fabric_arm_axel_radius, $fn=100); |
No description provided.