Skip to content

Support default alert config #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gluckzhang merged 6 commits into from
Jul 1, 2025
Merged

Support default alert config #42

gluckzhang merged 6 commits into from
Jul 1, 2025

Conversation

@gluckzhang
Copy link
Member

@gluckzhang gluckzhang commented Jun 30, 2025 •
edited
Loading

Summary

  • add helper to copy default AlertConfig values
  • apply defaults when validating chain configs
  • expand default_alert_config in example config
  • add some unit tests and create a new GitHub action for running unit tests

@gluckzhang gluckzhang self-assigned this Jun 30, 2025
@gluckzhang gluckzhang added the enhancement New feature or request label Jun 30, 2025
@gluckzhang
add more comments to the example config and remove some legacy code
a13fb28 
Signed-off-by: Long Zhang <gluckzhang@gmail.com>
@gluckzhang
use pointers for storing alert configs to make overriding easier
bfefbb0 
Signed-off-by: Long Zhang <gluckzhang@gmail.com>
@gluckzhang
add unit tests and integrate with CI
d0462bf 
Signed-off-by: Long Zhang <gluckzhang@gmail.com>
@gluckzhang
format the code and remove some debug code
7b34dc5 
Signed-off-by: Long Zhang <gluckzhang@gmail.com>
@gluckzhang
chore: fix go version for unit testing, renaming
97c61d5 
Signed-off-by: Long Zhang <gluckzhang@gmail.com>
@gluckzhang gluckzhang merged commit e35e707 into main Jul 1, 2025
1 of 2 checks passed
@gluckzhang gluckzhang deleted the codex/add-default-alert-configuration-to-config.yml branch July 1, 2025 10:37
This was referenced Jul 1, 2025
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@gluckzhang gluckzhang

Labels

codex enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gluckzhang