Skip to content

#52 fix the similar issue in Namada provider #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gluckzhang merged 1 commit into from
Aug 29, 2025
Merged

#52 fix the similar issue in Namada provider #54

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions td2/provider-namada.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,8 +94,6 @@ func getVotingPeriodProposals(httpClient *http.Client, indexers []string) ([]gov
}

func (d *NamadaProvider) QueryUnvotedOpenProposals(ctx context.Context) ([]gov.Proposal, error) {
// Store the last error to return if all indexer endpoints fail
var lastErr error
var unVotedProposals []gov.Proposal

indexers, ok1 := d.ChainConfig.Provider.Configs["indexers"].([]any)
Expand Down Expand Up @@ -131,13 +129,11 @@ func (d *NamadaProvider) QueryUnvotedOpenProposals(ctx context.Context) ([]gov.P
// Make the HTTP request with context
req, err := http.NewRequestWithContext(ctx, "GET", reqURL, nil)
if err != nil {
lastErr = err
continue // Try next node
}

resp, err := httpClient.Do(req)
if err != nil {
lastErr = err
continue // Try next node
}

Expand All @@ -147,7 +143,6 @@ func (d *NamadaProvider) QueryUnvotedOpenProposals(ctx context.Context) ([]gov.P

var results []map[string]any
if err = json.NewDecoder(resp.Body).Decode(&results); err != nil {
lastErr = err
return // Exit this func, continue loop
}

Expand All @@ -169,7 +164,7 @@ func (d *NamadaProvider) QueryUnvotedOpenProposals(ctx context.Context) ([]gov.P
}
}

return unVotedProposals, lastErr
return unVotedProposals, nil
}

func (d *NamadaProvider) QueryValidatorInfo(ctx context.Context) (pub []byte, moniker string, jailed bool, bonded bool, delegatedTokens float64, commissionRate float64, err error) {
Expand Down
Loading