Don't embed a platform string for non-native apps #137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Liam McLoughlin <lmcloughlin@fitbit.com>
Hexxeh
force-pushed
the
lmcloughlin/no-js-platform
branch
from
ba7249c to
f97b217
Compare
npclaudiu
approved these changes
Aug 15, 2019
gmaniak
approved these changes
Sep 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Embedding the FW version is unnecessary, we do versioning for JS apps based on API versions. Including these versions is just misleading and doesn't really help. They were just a legacy of pre-API version times.
Need to confirm site can deal with this, and won't offer a platform-less build to an old FW that advertised no API version support.