DaD: Add private external modules #304
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmaniak
requested review from
a team,
StefanRM,
alexberceanu90 and
dodgerblue
Hexxeh
reviewed
Nov 18, 2022
Hexxeh
reviewed
Nov 18, 2022
#### Summary of changes Add the possibility to import private modules into the toolchain. #### Description of testing Tested locally with private modules. The app transpiles successfully. Signed-off-by: Catalin Ghenea <gcatalin@google.com>
gmaniak
force-pushed
the
gcatalin/dad-add-private-modules
branch
from
9fdabb0 to
352195b
Compare
dodgerblue
approved these changes
Nov 21, 2022
Hexxeh
approved these changes
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Add the possibility to import private modules
into the toolchain.
Description of testing
Tested locally with private modules.
The app transpiles successfully.
Signed-off-by: Catalin Ghenea gcatalin@google.com