Add multiple_chart Method to GenericAsset for Exporting Individual Sensor Charts#1146
Draft
BelhsanHmida wants to merge 3 commits intomainfrom
Draft
Add multiple_chart Method to GenericAsset for Exporting Individual Sensor Charts#1146BelhsanHmida wants to merge 3 commits intomainfrom
BelhsanHmida wants to merge 3 commits intomainfrom
Conversation
Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>
nhoening
requested changes
Aug 16, 2024
Contributor
nhoening
left a comment
nhoening
left a comment
There was a problem hiding this comment.
A few quick ideas for refactoring a little.
… multiple_chart to charts, and refactor chart and charts methods to use the new function Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>
…try in . Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>
Contributor
|
This PR might still be worthwhile if we want to export single files to clients, but for now less urgent as we could seprate the legends within one graph. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This Pull Request introduces a new method
multiple_chartto theGenericAssetclass. This method is designed to facilitate the export of individual charts for different sensor groups. This supports the feature added in thesmart-buildingsrepository, allowing for the export of graphs one-by-one.Further Improvements
sensors_to_showformats as discussed in #1125 to handle more custom titles for charts.Related PRs:
This PR complements the changes made in the
smart-buildingsrepository under PR #288, which implements functionality for exporting individual charts based on this method. The associated issue is #242.