-
Notifications
You must be signed in to change notification settings - Fork 48
Fix/scheduling/sign #1348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Fix/scheduling/sign #1348
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
f78f51e
docs: clarify inline comment
Flix6x 32f92c3
fix: the sign should be switched if consumption is positive, and the …
Flix6x ea72f0d
Merge remote-tracking branch 'refs/remotes/origin/main' into fix/sche…
Flix6x 568f77d
Merge branch 'main' into fix/scheduling/sign
nhoening 9d4b8da
Merge branch 'main' into fix/scheduling/sign
nhoening 5be69a3
Merge remote-tracking branch 'refs/remotes/origin/main' into fix/sche…
Flix6x 58b5c6e
Merge remote-tracking branch 'refs/remotes/origin/main' into fix/sche…
Flix6x 77bc392
Merge remote-tracking branch 'origin/main' into fix/scheduling/sign
Flix6x 60b77a1
docs: main changelog entry
Flix6x df60830
docs: fix typo
Flix6x a9cf916
docs: API changelog entry
Flix6x b06a2ad
delete: remove long deprecated scheduling modules
Flix6x b74b42d
feat: allow identification of time series before and after the switch
Flix6x 81473b2
docs: add changelog warning
Flix6x 78647c8
small fixes in links of tutorial (scripts)
nhoening e084006
minimum documentation improvement currently possible
nhoening File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't find an answer to my own question: If we follow the USEF default that consumption is positive, why does this attribute "consumption_is_positive" default to False now ??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just read in a comment that we are " setting the attribute purposely incorrectly".
Can we plan a follow-up where these things are actually name and described properly? I am spending a lot of time now trying to make sense of it, but I couldn't even if we used it the correct way around.
Let's have a session where we make this user-friendly.
On a positive note, I ran all tutorials, and all schedules look exactly as they have been documented earlier.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Setting the default to save consumption as negative values in the db is mentioned in the original issue description, but I agree it is not thoroughly reasoned - instead, I only mentioned the new default would agree with some inline comment, telling us that consumption is negative in the db (which isn't strictly true anymore - even before this PR, and perhaps it would be better to state this is the default for the db, which only comes into play when the
consumption_is_positiveattribute is not explicitly set).So why is that the default for the db? I believe that, historically, we started out with a grid perspective for our db, where production is adding energy to the grid (positive), and consumption is taking it away (negative), and we took a USEF perspective only for our API, which flipped the sign convention.
I am not entirely against changing the default for the db, given that FlexMeasures has transitioned into placing behind-the-meter optimization first. However, we would again have to go through various (field) tests to come up with the correct revision/migration that doesn't unexpectedly flip schedules for end users. As an alternative, I could imagine only changing the default for new power sensors, by defaulting the
consumption_is_positiveattribute for new sensors toTrue.I hope this is valuable input for the session you request.
And really glad to hear the tutorials are unaffected, too!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I forgot tot check the issue.
Good to learnore about the history.
But this seems now to be a conceptual hurdle for users. I hope we find a pathway that creates clarity.