fix: selection of a data source from multiple data sources

[Ahmad-Wahid]

Fixes:

[nhoening]

Thanks!

[Flix6x]

Why was this needed, actually? I would have expected only a single source when filtering by name, model, version and type. Maybe this points to a missing unique constraint on the datasource table?

For your consideration: is silently selecting the first among multiple sources worth logging a warning? Or is this a regular expected case?

[Ahmad-Wahid]

Why was this needed, actually? I would have expected only a single source when filtering by name, model, version and type. Maybe this points to a missing unique constraint on the datasource table?

For your consideration: is silently selecting the first among multiple sources worth logging a warning? Or is this a regular expected case?

We have got three data sources(duplicate) and i think all of them have data. I'm not able to query data even after applying a limit.

[Flix6x]

My recommendations:

• check if creating another duplicate data source leads to a db error
  • if it doesn't raise a db error, we could discuss a db migration where we add a suitable constraint and we could add a CLI command to merge duplicate sources
  • if it does, then I'm puzzled at how that db ended up in this state, but we may still write a CLI option to merge sources.
• in case this function runs into multiple sources, we could raise and refer to the new CLI command.
• the smart-buildings plugin is using the source name to uniquely identify a data source. Perhaps it should be using an ID instead.